Rework rpm building #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
force-pushed
the
rpm_do_over
branch
from
a57ea65 to
5d5855d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the RPM build process by leveraging pixi for building the source tarball and updating the pyproject.toml file, while also simplifying the overall maintenance of the build scripts. Key changes include:
- Introducing pixi commands in rpmbuild.sh to replace traditional build commands.
- Lowering the required Python version in pyproject.toml and adding a new build-sdist task.
- Removing the pyproject.patch file and adjusting the finddata.spec file for version and packaging updates.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rpmbuild.sh | Added pixi installation check and build commands; modified tarball extraction path. |
| pyproject.toml | Adjusted Python version requirement and added a new build-sdist task under pixi tasks. |
| pyproject.patch | Removed outdated patch file related to pyproject.toml changes. |
| finddata.spec | Updated package version and Python package version definition; removed patch usage. |
Comments suppressed due to low confidence (3)
finddata.spec:5
- Confirm that defining the python package version as '3' is compatible with all target environments and does not introduce ambiguity.
%define python3_pkgversion 3
rpmbuild.sh:35
- Verify that the tarball is reliably being placed in the 'sdist' directory as expected by this extraction command.
tar xzf "sdist/${TARBALL_SRC}" --strip 1 -C "python-finddata-${VERSION}" || exit 127
pyproject.toml:9
- Ensure that lowering the minimum required Python version from 3.11 to 3.9 is fully supported and verified across the project.
requires-python = ">=3.9"
This takes advantage of pixi for creating the source tarball then edits the contents of pyproject.toml while renaming the unpacking directory. The change should be less effort to maintain than a patchfile.
peterfpeterson
force-pushed
the
rpm_do_over
branch
from
5d5855d to
8789076
Compare
KedoKudo
reviewed
Jun 5, 2025
|
|
||
| [tool.pixi.tasks] | ||
| # PyPI | ||
| build-sdist = { cmd = "hatch build sdist", description = "Build the source distribution (tar.gz)" } |
Member
There was a problem hiding this comment.
should probably adding this to the template repo in case other projects need similar features.
KedoKudo
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of pixi for creating the source tarball then edits the contents of pyproject.toml while renaming the unpacking directory. The change should be less effort to maintain than a patchfile.
The new package is installed on ndav. To test
References
EWM11625