This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Update ExpGPIO class to fix configure initialstate bug#6
Open
DoronShapiro wants to merge 1 commit intonewrelic:masterfrom
Open
Update ExpGPIO class to fix configure initialstate bug#6DoronShapiro wants to merge 1 commit intonewrelic:masterfrom
DoronShapiro wants to merge 1 commit intonewrelic:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if
configureis called on a digital out pin from the ExpGPIO class with an initial state, (e.g.ExpGPIO(ioexp, 10).configure(DIGITAL_OUT, 1);, the initial state is treated as a callback and the pin is initialized with its default value of 0.This commit drops in the updated ExpGPIO class from https://github.com/electricimp/reference/blob/master/hardware/expGpio/expGpio.device.nut that gives ExpGPIO's
configurefunction the same interface as the standard pin'sconfigurefunction.