-
Notifications
You must be signed in to change notification settings - Fork 133
Guard Azure Functions Utilization #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
+ Coverage 81.65% 81.69% +0.03%
==========================================
Files 209 209
Lines 24392 24387 -5
Branches 3870 3869 -1
==========================================
+ Hits 19918 19923 +5
+ Misses 3162 3153 -9
+ Partials 1312 1311 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa99b11 to
e843f48
Compare
| if website_owner_name and "+" in website_owner_name: | ||
| subscription_id = website_owner_name.split("+")[0] or "Unknown" | ||
|
|
||
| resource_group_name = os.environ.get("WEBSITE_RESOURCE_GROUP", "Unknown") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest issue here is that the WEBSITE_RESOURCE_GROUP environment variable is not guaranteed to be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More specifically, it is not present in the Consumer plan and it is not always present in the Flex Consumer plan at the time we would need the value of this.
|
|
||
|
|
||
| def test_utilization(monkeypatch): | ||
| monkeypatch.setenv("REGION_NAME", "EastUS2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this is case sensitive when being passed into the application: it should be all lowercase
| monkeypatch.setenv("REGION_NAME", "EastUS2") | |
| monkeypatch.setenv("REGION_NAME", "eastus2") |

Overview