Open
Conversation
serverwizard
requested changes
Aug 30, 2023
serverwizard
left a comment
serverwizard
left a comment
There was a problem hiding this comment.
작성하신 테스트 코드까지는 잘 작성해 주셨네요 👍
나머지 부분도 작성해 주시면 좋을 것 같아요~
그리고 생각해 보면 좋을 법한 코멘트도 남겨두었는데 참고 부탁드릴게요 🙏
|
|
||
| import java.util.UUID; | ||
|
|
||
| public class MenuGroupFixtures { |
| import static org.mockito.BDDMockito.when; | ||
|
|
||
| @DisplayName("메뉴") | ||
| public class MenuServiceTest extends ApplicationTest { |
There was a problem hiding this comment.
메뉴 가격 변경 및 메뉴 노출 로직에 대해서도 테스트 코드를 작성해보시면 좋을 것 같아요 :)
기존 레거시 코드에 버그가 숨어 있을 수도 있잖아요~
| void contextLoads() { | ||
| } | ||
| } | ||
| @ExtendWith(MockitoExtension.class) |
There was a problem hiding this comment.
Mockito를 이용하여 테스트 코드를 작성해 주셨네요 :)
혹시 통합 테스트 또는 가짜 객체를 사용해서 테스트 코드를 작성할 수도 있었을텐데 그렇게 하지 않은 이유는 어떤 걸까요?
- 이렇게 질문 드린 이유는 이런 고민 과정을 통해 특정 상황에서 자신만의 기준을 확립해 나가시면 좋을 듯 해서예요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product, menuGroup, menu 에 대한 테스트 코드 먼저 pr 요청 드립니다.
추후에 menu 일부와 order,orderTable 도 추가로 작성하도록 하겠습니다.