2단계 - 수강신청(도메인 모델) #818
Open
2단계 - 수강신청(도메인 모델) #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
requested changes
Dec 16, 2025
Contributor
javajigi
left a comment
javajigi
left a comment
There was a problem hiding this comment.
지금까지 학습한 내용을 바탕으로 2단계 미션 진행 💯
현 상태로 바로 merge해도 되는데요.
db 매핑하기 전에 한번 더 고민해 봤으면 하는 내용이 있어 피드백 남겨 봅니다.
추가로 sessions/domin 패키지에 도메인 객체 수가 많아지는데요.
패키지 분리 리팩터링도 이번 기회에 도전해 보면 어떨까요?
|
|
||
| private final Integer maxCapacity; | ||
| private final boolean unlimited; | ||
| private final int enrollCount; |
Contributor
There was a problem hiding this comment.
db가 아닌 도메인 객체인 만큼 수강생 목록을 가지는 것은 어떨까?
db를 고려해 구현한 것은 아닐까?
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| public class Session { |
Contributor
There was a problem hiding this comment.
Session의 필드 수가 많다.
Session의 기본 정보를 가지는 필드(현재 SessionInfo)와 수강신청에 관여하는 필드 값을 하나의 객체로 묶은 후 수강 신청 로직을 이 객체가 담당하도록 역할을 부여하는 것은 어떨까?
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| class SessionTestBuilder { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요.
2단계 - 수강신청(도메인 모델) PR 입니다.