-
Notifications
You must be signed in to change notification settings - Fork 32
[김헌승] 프리코스 미션 제출합니다. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimheonseung
wants to merge
19
commits into
next-step:main
Choose a base branch
from
kimheonseung:feature/weather-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 5개 도시(Seoul, Tokyo, NewYork, Paris, London) 지원 - 도시 이름으로 City 조회 기능 추가 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- WeatherCodeTranslator 클래스로 하늘 상태 번역 - 맑음, 흐림, 비, 눈 등 다양한 날씨 상태 지원 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- OpenMeteoResponse, WeatherResponse DTO 추가 - WeatherSummaryGenerator로 한 줄 요약 문장 생성 - WeatherService에서 Open-Meteo API 호출 및 응답 변환 - WeatherController로 REST API 엔드포인트 제공 - CityNotFoundException 예외 처리 추가 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- CityTest: 도시 조회, 대소문자 무시, 좌표 검증 - WeatherCodeTranslatorTest: WMO 코드 변환 검증 - WeatherSummaryGeneratorTest: 요약 문장 생성 검증 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- buildWeatherResponse를 createSummary, createWeatherResponse로 분리 - 프로그래밍 요구사항(메서드 15줄 이하) 준수 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 프로그래밍 요구사항 (코드 스타일, 제약사항) - AngularJS Git Commit Convention 가이드 - 작업 순서 안내 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 유효한 도시 요청 시 200 OK 응답 검증 - 지원하지 않는 도시 요청 시 400 Bad Request 검증 - city 파라미터 누락 시 400 Bad Request 검증 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- application.properties를 application.yml로 변경 - Safari 브라우저 한글 호환성을 위해 force-response 설정 추가 - build.gradle.kts에 JavaCompile UTF-8 인코딩 설정 추가 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- ErrorResponse DTO로 공통 에러 응답 규격 정의 - GlobalExceptionHandler(@RestControllerAdvice)로 예외 처리 통합 - WeatherController에서 예외 핸들러 제거 - 컨트롤러 테스트에서 에러 응답 검증 추가 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 진행 흐름 (과제 분석 → API 조사 → 구현 → 검증 → 보완) - AI 활용으로 수정한 내용 (요구사항 준수, 브라우저 호환성, 테스트 보완 등) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 구현 전략을 1차/2차로 분리 - AI 활용 내역을 1차 작업으로 정리 - 2차 작업 개선 목표 추가 (DB 전환) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- environment/docker-compose.yml로 MySQL 컨테이너 구성 - application.yml에 MySQL 데이터소스 설정 추가 - Flyway 마이그레이션으로 city, weather_code 테이블 생성 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- City 엔티티 및 CityRepository 추가 - WeatherCode 엔티티 및 WeatherCodeRepository 추가 - WeatherCodeTranslator가 DB에서 매핑 정보 조회하도록 변경 - WeatherController가 CityRepository를 사용하도록 변경 - 기존 City enum 삭제 - 테스트용 H2 설정 및 data.sql 추가 - 테스트 코드를 DB 기반으로 수정 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 2차 구현 전략 업데이트 - 2차 작업 진행 흐름 및 AI 활용 내용 추가 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- CityReadService 추가 (@transactional readOnly) - WeatherController가 CityReadService를 통해 도시 조회 - 컨트롤러 테스트 수정 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- 레이어 구조 개선 내용 추가 (CityReadService, readOnly 트랜잭션) - 실행 방법 섹션 추가 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.