Skip to content

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Nov 17, 2025

  • Migrate to Vue 3 and nc/vue 9.2.0
  • Use NcFormBoxSwitch instead of NcCheckboxRadioSwitch
  • Use labels of NcInputField and NcTextField

closes #689

Before After
image image
image image

@julien-nc julien-nc added this to the Nextcloud 33 milestone Nov 17, 2025
@julien-nc julien-nc added enhancement New feature or request gui labels Nov 17, 2025
@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch 2 times, most recently from 189a9ee to 86757e4 Compare November 17, 2025 11:58
@julien-nc julien-nc linked an issue Nov 17, 2025 that may be closed by this pull request
@julien-nc julien-nc requested a review from kra-mo November 17, 2025 13:14
@julien-nc
Copy link
Member Author

@kra-mo Hey! What do you think about those screenshots?

@julien-nc julien-nc marked this pull request as ready for review November 17, 2025 13:17
Base automatically changed from enh/noid/strings to main November 17, 2025 15:51
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the screenshots, it looks a lot nicer :)

Two things I guess that I would change are:

  • Making the Hide deploy options buttons full-width
  • Using regular, secondary-styled buttons for the i info buttons. Unless they are only activated on hover? But then they really shouldn't be as that is not accessible :)

@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch from 0de0a2a to 8f2f474 Compare November 18, 2025 10:42
@julien-nc
Copy link
Member Author

julien-nc commented Nov 18, 2025

@kra-mo Thank you!

Making the Hide deploy options buttons full-width

Done

Using regular, secondary-styled buttons for the i info buttons. Unless they are only activated on hover? But then they really shouldn't be as that is not accessible :)

I removed the color but kept tertiary. I think they are catching the eye too much when they are secondary. Wdyt?

I updated the screenshots.

What do you think about making the modal footer sticky? (always show it at the bottom without having to scroll)

Kooha-2025-11-18-12-16-39.webm

@julien-nc julien-nc requested a review from kra-mo November 18, 2025 11:18
@kra-mo
Copy link
Member

kra-mo commented Nov 18, 2025

I removed the color but kept tertiary. I think they are catching the eye too much when they are secondary. Wdyt?

I was originally gonna write tertiary but I changed my mind :)

It's about layout vs. prominence. Something to think about later for Design.

But tertiary looks good and is consistent with similar items, so keep it.

What do you think about making the modal footer sticky? (always show it at the bottom without having to scroll)

Yeah, definitely makes sense :)

@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch from afe8c27 to a5bc8ac Compare November 18, 2025 12:16
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…figModal

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch 2 times, most recently from 81ebc0a to 5b2e937 Compare November 19, 2025 13:42
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch from aefe086 to cf63f29 Compare November 19, 2025 13:59
@nextcloud-command nextcloud-command force-pushed the enh/689/settings-reorganization branch from cf63f29 to 9add075 Compare November 19, 2025 14:39
@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch 4 times, most recently from 13b14d3 to ddecc8b Compare November 19, 2025 16:41
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/689/settings-reorganization branch from 30d3cbc to a48277c Compare November 19, 2025 17:34
@julien-nc
Copy link
Member Author

/compile fixup

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - looks very beutiful 👌

@julien-nc julien-nc merged commit 62640ad into main Nov 20, 2025
35 checks passed
@julien-nc julien-nc deleted the enh/689/settings-reorganization branch November 20, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppAPI settings reorganization

5 participants