-
Notifications
You must be signed in to change notification settings - Fork 16
Settings reorganization #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
189a9ee to
86757e4
Compare
|
@kra-mo Hey! What do you think about those screenshots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the screenshots, it looks a lot nicer :)
Two things I guess that I would change are:
- Making the Hide deploy options buttons full-width
- Using regular, secondary-styled buttons for the i info buttons. Unless they are only activated on hover? But then they really shouldn't be as that is not accessible :)
0de0a2a to
8f2f474
Compare
|
@kra-mo Thank you!
Done
I removed the color but kept tertiary. I think they are catching the eye too much when they are secondary. Wdyt? I updated the screenshots. What do you think about making the modal footer sticky? (always show it at the bottom without having to scroll) Kooha-2025-11-18-12-16-39.webm |
I was originally gonna write tertiary but I changed my mind :) It's about layout vs. prominence. Something to think about later for Design. But tertiary looks good and is consistent with similar items, so keep it.
Yeah, definitely makes sense :) |
afe8c27 to
a5bc8ac
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…figModal Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
81ebc0a to
5b2e937
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
aefe086 to
cf63f29
Compare
cf63f29 to
9add075
Compare
13b14d3 to
ddecc8b
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
30d3cbc to
a48277c
Compare
|
/compile fixup |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
oleksandr-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - looks very beutiful 👌
closes #689