Skip to content

fix(CirclesManager): Use correct return type for probeCircles #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Feb 5, 2026
+7 −7
Merged

fix(CirclesManager): Use correct return type for probeCircles #2337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/CirclesManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ public function getDefinition(IEntity $circle): string {
* @param CircleProbe|null $circleProbe
* @param DataProbe|null $dataProbe
*
* @return array
* @return list<Circle>
* @throws InitiatorNotFoundException
* @throws RequestBuilderException
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/Db/CircleRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public function probeCircle(
* @param CircleProbe $circleProbe
* @param DataProbe $dataProbe
*
* @return Circle[]
* @return list<Circle>
* @throws RequestBuilderException
*/
public function probeCircles(
Expand Down
4 changes: 2 additions & 2 deletions lib/Db/CircleRequestBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ public function getItemFromRequest(CoreQueryBuilder $qb): Circle {
/**
* @param CoreQueryBuilder $qb
*
* @return Circle[]
* @return list<Circle>
*/
public function getItemsFromRequest(CoreQueryBuilder $qb): array {
/** @var Circle[] $result */
/** @var list<Circle> $result */
return $qb->asItems(Circle::class);
}
}
2 changes: 1 addition & 1 deletion lib/Service/CircleService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ public function probeCircle(
* @param CircleProbe $circleProbe
* @param DataProbe|null $dataProbe
*
* @return Circle[]
* @return list<Circle>
* @throws InitiatorNotFoundException
* @throws RequestBuilderException
*/
Expand Down
4 changes: 2 additions & 2 deletions lib/Tools/Db/ExtendedQueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ public function asItem(string $object, array $params = []): IQueryRow {
* @param string $object
* @param array $params
*
* @return IQueryRow[]
* @return list<IQueryRow>
*/
public function asItems(string $object, array $params = []): array {
return $this->getRows([$this, 'parseSimpleSelectSql'], $object, $params);
Expand Down Expand Up @@ -1012,7 +1012,7 @@ public function getRow(callable $method, string $object = '', array $params = []
* @param string $object
* @param array $params
*
* @return IQueryRow[]
* @return list<IQueryRow>
*/
public function getRows(callable $method, string $object = '', array $params = []): array {
$rows = [];
Expand Down
Loading