Multiple fixes and add Group Backend support#384
Closed
tortuetorche wants to merge 11 commits intonextcloud:masterfrom
Closed
Multiple fixes and add Group Backend support#384tortuetorche wants to merge 11 commits intonextcloud:masterfrom
tortuetorche wants to merge 11 commits intonextcloud:masterfrom
Conversation
e4ee7a9 to
459d92c
Compare
Contributor
Author
|
Hi @daita, Can you tell me if I need to split this big pull request in one pull request per commit, please? Have a good day, |
Member
|
Hello, Thanks for this huge commit, but I would prefer a list of small PR instead ! (also, some of those are already fixed ;p) Regards, |
Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Fix nextcloud#243 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Fix nextcloud#342 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
…o_closed_circles` option is enabled Fix nextcloud#382 and nextcloud#360 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Including `name` and `description` attributes Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
…oup members from any users Default to `1`. When value is set to `0` it's only possible to add groups where the current user is a member or for global administrators. Fix nextcloud#128 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
… Circles app Default value is `1` to show circles in shared list. Set it to `0` to hide them. Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
…n the files app Default is set to `1` to list them in the `files` application To hide them, set it to `0` Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
The main goal is to have better integrations with Nextcloud applications and clients. The group name is automatically suffixed by ` Circle` And you can customize the prefix and/or suffix group name with the `group_backend_name_prefix` and `group_backend_name_suffix` options You should also hide these mirrored circles in Nextcloud applications and clients, because their equivalent group will be used instead, via the `allow_listed_circles` option set to `0`. Fix nextcloud#363 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Contributor
Author
|
Hi @daita,
It's done, here my pull requests: #390, #391, #392, #393, #394, #395, #396, #397, #398, #399, #400 and #401! NB: You should merge them in the ascendant order, otherwise some issues might appears... Have a good day, |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced May 3, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
This was referenced Apr 4, 2024
Member
|
Closing since this PR was subsequently handled through split up PRs: #384 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This big pull request will be eventually split in multiple pull requests...
group_backendoption to mirroring the circle as a group (automatically suffixed byCircle)You can customize prefix and suffix with the
group_backend_name_prefixandgroup_backend_name_suffixoptionsThe main goal is to have better integrations with Nextcloud applications and clients. (fix Offer setting so that any circle creates a group #363)
You should also hide these mirrored circles in Nextcloud applications and clients, because their equivalent group will be used instead, via the
allow_listed_circlesoption set to0group_backendoption is enabled, store the mirrored group id in thegroup_idcolumn of thecircles_circlestable, useful when the circle's name is updatedallow_listed_circlesTo show (1, default) or hide (0) circles in shared list, disabling this option is very useful when thegroup_backendoption is enabledpersonalandsecretcircles from Group backend, if thegroup_backendoption is enabledonSettingsChangeevent to get old setting values (includingnameanddescriptionattributes).allow_adding_any_group_membersoption to allow (1, default) or not adding group members from any users. When value is set to0it's not possible anymore to add contacts as circle members forprivateandpubliccircle types, and it's only possible for groups where the current user is a member or for global administrators. Because they can't be group members, useful when thegroup_backendoption is enabled. There is already theaccounts_onlyoption but it applied for any types of circles... (fix Non-admin users should not be able to add group(s) to circles #128)personalcircles whenskip_invitation_to_closed_circlesoption is enabled (fix Circle - Can't add persons in personal circle by activating skip invation for closed circle in settings #382 and add users without confirmation in a closed group #360)-1or0(fix Add group doesn't work with member limit -1|0 #342)