Open
Conversation
ArtificialOwl
force-pushed
the
fix/noid/share-with-group-members-only
branch
2 times, most recently
from
6b4d492 to
6dd5c8e
Compare
PVince81
reviewed
Mar 10, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
code looks ok, not sure if this is still a draft?
| $event = new FederatedEvent(SingleMemberAdd::class); | ||
| $event->setCircle($circle); | ||
| $event->setMember($member); | ||
| $event->getParams()->sBool('force_group_member', true); |
Member
There was a problem hiding this comment.
is sBool the equivalent of setBool ?
| continue; | ||
| } | ||
|
|
||
| echo 'NO NON ' . json_encode($circle) . "\n"; |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/share-with-group-members-only
branch
from
6dd5c8e to
402e0ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
===========================================
- Coverage 0.70% 0.69% -0.01%
- Complexity 5735 5777 +42
===========================================
Files 290 290
Lines 19822 19940 +118
===========================================
Hits 139 139
- Misses 19683 19801 +118
Continue to review full report at Codecov.
|
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
This was referenced May 3, 2023
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
This was referenced Jan 29, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.