fix(HTMLPurifier): Disable Serializer cache to avoid stray files for now#248
Open
joshtrichards wants to merge 206 commits intocms_pico-1.0from
Open
fix(HTMLPurifier): Disable Serializer cache to avoid stray files for now#248joshtrichards wants to merge 206 commits intocms_pico-1.0from
joshtrichards wants to merge 206 commits intocms_pico-1.0from
Conversation
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Adding Pico's DummyPlugin as example plugin hopefully encourages users to develop their own plugins 😃 Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Closes #123 Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Spelling unification in Transifex. Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
HTMLSerializer uses the path the library is installed it as the cache by default. Since other Nc apps use HTMLSerialize, the app who's copy of HTMLSerialize happens to get used first, ends up with a bunch of stray cache files. Besides being messy, this brings things like integrity checks. See nextcloud/mail#9731 There are three choices here: - disable the cache (this what the Nc `mail` app does) - leave it enabled by specifying a path - accept it as is Performance impact of disabling is unknown. If we eventually want this enabled still in Pico, we can set `Cache.SerializePath` to somewhere we're comfortable saving data (locally on the instance...). Ref: http://htmlpurifier.org/live/configdoc/plain.html#Cache.DefinitionImpl Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
|
Good catch, thanks! ❤️ Could you please cherry-pick your commit on the However, please note that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTMLSerializer uses the path the library is installed it as the cache by default. Since other Nc apps use HTMLSerialize, the app who's copy of HTMLSerialize happens to get used first, ends up with a bunch of stray cache files. Besides being messy, this brings things like integrity checks.
See nextcloud/mail#9731
FIxes nextcloud/mail#9731
There are three choices here:
mailapp does)Performance impact of disabling is unknown. If we eventually want this enabled still in Pico, we can set
Cache.SerializePathto somewhere we're comfortable saving data (locally on the instance...).Ref: http://htmlpurifier.org/live/configdoc/plain.html#Cache.DefinitionImpl