Fix for Nextcloud 31 compatibility#255
Conversation
Added compatibility information for Nextcloud 26 and noted potential issues with HTML purifier. Signed-off-by: Joanny Krafft <144920174+jkraffthha@users.noreply.github.com>
Clarified compatibility notes and improved language. Signed-off-by: Joanny Krafft <144920174+jkraffthha@users.noreply.github.com>
|
Thank you for your contribution! 👍 However, most of this (but not all, like the bootstrap class) has been fixed in the This also creates a merge conflict with your PR. You can rebase if you want to, but please note that I'm not going to merge it (or any other PR for this matter), because: Pico CMS for Nextcloud has long reached its end-of-life. See 1fbe212 for details. Since Pico (https://github.com/picocms/Pico) has reached its end-of-life too and nobody is willing to take up responsibility, both Pico and the Pico users can keep on using standalone Pico, but users of the Nextcloud app really should not: Integrating Pico into Nextcloud is a very delicate matter. It can easily create major security issues for your Nextcloud instance: If users manage to integrate active contents into their website, they could potentially take over the whole Nextcloud instance. Thus it's a very, very bad idea to keep on using the Nextcloud app. Personally I wouldn't even use it with an updated version of HTMLPurifier, but with the ancient version I'm very sorry, but Pico CMS for Nextcloud is really dead and shouldn't be used right now 😞 Bringing it back to life wouldn't just require one to fix the few compatibility issues, but revive both Pico and the Nextcloud app, and to give at least a medium-term commitment to provide said minimum guarantee of support. See picocms/Pico#716 for more details. |
|
Hi, |
I've made a fix to make cms_pico compatible with nextcloud 31.
For that I've change the app structure using bootstrap.
The main issue was the replacement of ILogger by LoggerInterface.
I haven't been able to make the HTMLPurifier work properly (for now), so I'm bypassing it, which might be an issue (it's not in my current user case).
I've only been able to test it on two seperate Nextcloud instance running Nextcloud 31.