feat: show confirmation when enabling team federation and remove team from parents#5103
Closed
cristianscheid wants to merge 1 commit intomainfrom
Closed
feat: show confirmation when enabling team federation and remove team from parents#5103cristianscheid wants to merge 1 commit intomainfrom
cristianscheid wants to merge 1 commit intomainfrom
Conversation
6 tasks
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
… from parents Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
feat/2341/team-federation-confirmation-parent-removal
branch
from
a5c68a3 to
c554413
Compare
cristianscheid
added
3. to review
Contributor
Author
|
Closing this PR since we decided to move forward with a simpler solution instead (see #5109). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shows confirmation modal when enabling federation for a team, and if confirmed triggers action to remove the team from all teams it belongs to
Before
before.webm
After
after.webm
Checklist
3. to review, feature component)stable32)