Skip to content

Fix empty model list for image, tts, and stt when not overriden #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasdotcom merged 1 commit into from
Feb 12, 2026
+13 −0
Merged

Fix empty model list for image, tts, and stt when not overriden #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Cron/RefreshModels.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

namespace OCA\OpenAi\Cron;

use OCA\OpenAi\AppInfo\Application;
use OCA\OpenAi\Service\OpenAiAPIService;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\TimedJob;
Expand All @@ -27,5 +28,9 @@ public function __construct(
protected function run($argument) {
$this->logger->debug('Run daily model refresh job');
$this->openAIAPIService->getModels(null, true);
$this->openAIAPIService->getModels(null, true, Application::SERVICE_TYPE_TTS);
$this->openAIAPIService->getModels(null, true, Application::SERVICE_TYPE_STT);
$this->openAIAPIService->getModels(null, true, Application::SERVICE_TYPE_IMAGE);

}
}
8 changes: 8 additions & 0 deletions lib/Service/OpenAiAPIService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,14 @@ private function isModelListValid($models): bool {
* @throws Exception
*/
public function getModels(?string $userId, bool $refresh = false, ?string $serviceType = null): array {
// Use default service type if service type is not overridden
if ($serviceType === Application::SERVICE_TYPE_IMAGE && !$this->openAiSettingsService->imageOverrideEnabled()) {
$serviceType = null;
} elseif ($serviceType === Application::SERVICE_TYPE_STT && !$this->openAiSettingsService->sttOverrideEnabled()) {
$serviceType = null;
} elseif ($serviceType === Application::SERVICE_TYPE_TTS && !$this->openAiSettingsService->ttsOverrideEnabled()) {
$serviceType = null;
}
$cache = $this->cacheFactory->createDistributed(Application::APP_ID);
$userCacheKey = Application::MODELS_CACHE_KEY . '_' . ($userId ?? '') . '_' . ($serviceType ?? 'main');
$adminCacheKey = Application::MODELS_CACHE_KEY . '-main' . '_' . ($serviceType ?? 'main');
Expand Down
Loading