Skip to content

fix(attachements): unify icons with the rest of nextcloud#12421

Merged
kesselb merged 1 commit intomainfrom
fix/attachement-icons
Feb 17, 2026
Merged

fix(attachements): unify icons with the rest of nextcloud#12421
kesselb merged 1 commit intomainfrom
fix/attachement-icons

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Feb 13, 2026

Use OCP\Files\IMimeTypeDetector instead of custom icons to maintain the same UI across all of Nextcloud

b a
image image

@hamza221
Copy link
Contributor Author

/backport to stable5.7

@kesselb
Copy link
Contributor

kesselb commented Feb 13, 2026

Failure related:

1) OCA\Mail\Tests\Integration\Service\DraftServiceIntegrationTest::testSaveAndGetMessage
TypeError: OCA\Mail\Service\Attachment\AttachmentService::__construct(): Argument #8 ($mimeTypeDetector) must be of type OCP\Files\IMimeTypeDetector, Psr\Log\NullLogger given, called in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/tests/Integration/Service/DraftServiceIntegrationTest.php on line 95

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@kesselb kesselb force-pushed the fix/attachement-icons branch from fa9233b to ea58f99 Compare February 17, 2026 16:03
@kesselb kesselb enabled auto-merge February 17, 2026 16:03
@kesselb kesselb disabled auto-merge February 17, 2026 16:53
@kesselb kesselb merged commit 3d86ab2 into main Feb 17, 2026
41 of 42 checks passed
@kesselb kesselb deleted the fix/attachement-icons branch February 17, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments