Skip to content

refactor(comments): migrate to Vue 3#58353

Draft
edward-ly wants to merge 3 commits intomasterfrom
refactor/55428/comments
Draft

refactor(comments): migrate to Vue 3#58353
edward-ly wants to merge 3 commits intomasterfrom
refactor/55428/comments

Conversation

@edward-ly
Copy link
Contributor

Summary

TODO

Currently, npm run dev/build fails with this error. I suspect it has something to do with the CommentInstance class requiring a Vue 2 options object which I'm not yet sure how to cleanly migrate to Vue 3.

error during build:
[vite:css-post] object null is not iterable (cannot read property Symbol(Symbol.iterator))
    at assetFileNames (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/.vite-temp/vite.config.ts.timestamp-1771208851828-a019a06c76d568.mjs:95:33)
    at Object.assetFileNames (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/@nextcloud/vite-config/dist/plugins/CSSEntryPoints.js:28:65)
    at generateAssetFileName (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21662:25)
    at FileEmitter.finalizeAdditionalAsset (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21955:28)
    at FileEmitter.emitAssetWithReferenceId (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21899:18)
    at FileEmitter.emitAsset (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21884:18)
    at FileEmitter.emitFile (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21745:25)
    at Object.renderChunk (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/vite/dist/node/chunks/config.js:29806:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async transformChunk (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:20311:16)

Checklist

Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly added this to the Nextcloud 34 milestone Feb 16, 2026
@edward-ly edward-ly added 3. to review Waiting for reviews feature: comments technical debt javascript ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: comments javascript ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant