[stable32] fix(propagator): Improve lock behavior of propagator#58368
Open
CarlSchwan wants to merge 2 commits intostable32from
Open
[stable32] fix(propagator): Improve lock behavior of propagator#58368CarlSchwan wants to merge 2 commits intostable32from
CarlSchwan wants to merge 2 commits intostable32from
Conversation
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
salmart-dev
and removed request for
a team
github-actions
bot
changed the title
CarlSchwan
changed the title
Fix possible dead locks when running the propagator caused by two requests updating the same amount rows in transactions. - Lock rows always in the same deterministic order by sorting the path_hash first - On all database outside of sqlite, also do first a SELECT FOR UPDATE to lock all the rows used in batch UPDATE calls, afterward to decrease the risk of two requests trying to lock the same rows Signed-off-by: Carl Schwan <carlschwan@kde.org> (cherry picked from commit cae742d)
Signed-off-by: Carl Schwan <carlschwan@kde.org> (cherry picked from commit 3d031b0)
CarlSchwan
force-pushed
the
backport/58134/stable32
branch
from
1244503 to
fd2ae31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)