refactor(Setup/PostgreSQL): more robust credential handling and code organization#58391
Open
joshtrichards wants to merge 10 commits intomasterfrom
Open
refactor(Setup/PostgreSQL): more robust credential handling and code organization#58391joshtrichards wants to merge 10 commits intomasterfrom
joshtrichards wants to merge 10 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
And consolidate credential generation logic in a single place Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…le admin credentials Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
a5ed07d to
f9f27ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
$this->dbUser/$this->dbPassword) that made logic harder to follow, troubleshoot, or changeAfter:
Easiest to review probably by commit-by-commit
Specific improvements:
createDBUser()and only assigned to$this->after successuserExists()now accepts explicit "dbUser" parameterperformAutomaticSetup()introduced + less conditional logic depth)checkCanCreateRoles(),verifyDatabaseConnection(),grantCreateOnPublicSchema()$connectionobject/variable; less confusion between connection scenarios and more explicit lifecycle management'app' => 'pgsql.setup'to all log contextsTODO
Checklist
3. to review, feature component)stable32)