fix(Propagator): Skip groupfolders root entries#58402
Merged
provokateurin merged 1 commit intomasterfrom Feb 18, 2026
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
ArtificialOwl
and removed request for
a team
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
|
Might be better to have the groupfolder storage overwrite the propagator instead of having this logic in server. |
Member
Author
|
Right, I thought I'd have to override the whole propagateChange method, but of course it's enough to override the getParents method 👍 |
provokateurin
deleted the
fix/propagator/skip-groupfolders-root-entries
branch
provokateurin
restored the
fix/propagator/skip-groupfolders-root-entries
branch
Member
Author
|
I remember why I this needs to be in server 😅 The propagator for the groupfolders storage wouldn't handle these, as it only propagates within its storage, so overriding its getParents won't help at all. |
Member
Author
|
So I could add a custom propagator to LocalRootStorage and override getParents there, but in the end the fix has to be in server, so I don't think really matters. |
CarlSchwan
approved these changes
Feb 18, 2026
icewind1991
approved these changes
Feb 18, 2026
provokateurin
deleted the
fix/propagator/skip-groupfolders-root-entries
branch
8 tasks
Member
|
/backport to stable32 |
Member
|
/backport to stable33 |
Member
|
/backport to stable31 |
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the "old" storage layout where all groupfolders were on a single storage.
Any change to any groupfolder caused the
__groupfoldersentry to be updated, causing locking issues on instances with lots of concurrent users.This entry is actually not used at all by the clients, because only its subfolders are mounted, therefore the etag and mtime of it don't matter.