refactor(Setup/AbstractDatabase): enable easier child class customization and improve code readability, robustness#58412
Open
joshtrichards wants to merge 15 commits intomasterfrom
Open
refactor(Setup/AbstractDatabase): enable easier child class customization and improve code readability, robustness#58412joshtrichards wants to merge 15 commits intomasterfrom
joshtrichards wants to merge 15 commits intomasterfrom
Conversation
Also: - Switch to more modern str_contains() - Tidy up code formatting a bit Signed-off-by: Josh <josh.t.richards@gmail.com>
- Child classes can override specific validation rules more selectively (e.g. OCI override becomes simpler to avoid the dot check) - Improved code readability Signed-off-by: Josh <josh.t.richards@gmail.com>
… dot check Signed-off-by: Josh <josh.t.richards@gmail.com>
- Makes the undefined property explicit and required (less psalm baseline noise) - Forces child classes to implement it - Better type safety Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
And canonicalize "SQLite" properly Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…teDatabaseName() Signed-off-by: Josh <josh.t.richards@gmail.com>
- Improved readability - Easier child class customization Also added for certain config keys: a couple clarifying comments and additional error checking Signed-off-by: Josh <josh.t.richards@gmail.com>
Also: - add some helpful inline comments - simplify primary/replica param merging (same outcome) Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: install and update
♻️ refactor
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
changed the title
joshtrichards
requested review from
Altahrim,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Easiest to review commit-by-commit
validate()logicSetup/OCIoverride (to avoid the dot check) is streamlined$this->dbprettynameinitialize()logicconnect()logic / extracted port and socket parsing to a helper functionrunMigrations()Some misc minor robustness / modernization throughout.
TODO
Checklist
3. to review, feature component)stable32)