fix(files_sharing): Fix getting shares by path

[artonge]

• Match both parent and child share
• Improve path matching with /_%.
• Filter share by path in resolveSharesForRecipient

[artonge]

/backport to stable33

[nickvergessen]

Anything specific we can/should add test-wise? The PR description and commit message (fix) seem to indicate a bug, but I assume its only the upcoming performance improvement?

[artonge]

Anything specific we can/should add test-wise? The PR description and commit message (fix) seem to indicate a bug, but I assume its only the upcoming performance improvement?

My only question would be whether ROOMUSER share are expected to always exists. Because if one of them do not exist, then a share will be returned with a target set as {TALK_PLACEHOLDER}.

This might be linked to the failing tests on the PR.

[nickvergessen]

Because if one of them do not exist, then a share will be returned with a target set as {TALK_PLACEHOLDER}.

I assume the events BeforeShareCreatedEvent and VerifyMountPointEvent I mentioned in the chat took care of that in the past:

spreed/lib/Share/Listener.php

Lines 34 to 35 in c8c2121

	BeforeShareCreatedEvent::class => $this->overwriteShareTarget($event),
	VerifyMountPointEvent::class => $this->overwriteMountPoint($event),

So if one of them is no longer triggered when loading a specific share for a user, that's possible.

[nickvergessen]

The sharing-1 and features/sharing-4/update.feature Seems to be fixed by work from Robins PR in #16987 but it's breaking a new one.

So yeah, from talk's pov we always expect the Talk/ folder being used and that should result in the USERROM share, so we don't have to replace all the time and it's not moved when you change your directory later (e.g. in case you sort by Talk/$Year/ )

[artonge]

Backporting to see the result of CI on 33

[artonge]

/backport! to stable33

[artonge]

Oups, wrong repo push. Corrected.