WIP color scale domain includes legend anchors #2016
Draft
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the situation where the JSON defines legend anchors but not a scale by forcing the color-scale domain to include said anchors. The implementation is ok, but the legend/anchors block of the JSON scale isn't yet validated when we create the scale domain so we are using unvalidated data. Improving this would involve a bigger refactor which doesn't seem worth it at the moment. Needs more testing!
nextstrain-bot
temporarily deployed
to
auspice-james-anchors-i-obbk5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the situation where the JSON defines legend anchors but not a scale by forcing the color-scale domain to include said anchors.
The implementation is ok, but the legend/anchors block of the JSON scale isn't yet validated when we create the scale domain so we are using unvalidated data. Improving this would involve a bigger refactor which doesn't seem worth it at the moment.
Needs more testing!
cc @kimandrews