Skip to content

Conversation

@corneliusroemer
Copy link
Member

The special profile at profiles/default/config.yaml is used by snakemake >= 7.29 by default without requiring passing in via --profile profiles/default

Profiles are nice because they reduce number of CLI args required when invoking snakemake, e.g. one no longer needs to use --cores 1 or -c1 which became necessary in snakemake at some point.

With the default profile, one can simply run the tutorial by typing snakemake.

The special profile at `profiles/default/config.yaml` is used by snakemake >= 7.29
by default without requiring passing in via
`--profile profiles/default`

Profiles are nice because they reduce number of CLI args
required when invoking `snakemake`
@corneliusroemer corneliusroemer requested review from a team and huddlej September 15, 2023 09:23
@joverlee521
Copy link

This prompted me to read more about Snakemake profiles. Good to know that the default profile can be unset with --profile=none if you don't have another profile to provide.

@@ -0,0 +1,4 @@
cores: all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR overall looks good to me, but I wonder if this should be cores: 1 to better reflect how the current tutorial instructions tell people to run things?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think to not introduce the additional complexity of profiles here - we don't use use them for most pathogen repos.

If the goal is to remove the unnecessary --cores argument, we can already remove that - it's not required as of Nextstrain CLI 4.0.0.

@genehack
Copy link
Contributor

This PR seems to have become Warnocked — can we either determine what changes are required to allow it to be merged, or close it out?

@tsibley
Copy link
Contributor

tsibley commented Nov 22, 2024

I vote to close for the reasons Victor gave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

6 participants