Todo triage #40
Open
Todo triage #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes TODO comments for items marked as "won't do" during todo triage: - Allow service to be provided as positional argument - Error on invalid Operation instantiation - Support dynamic Operation creation - Rename operation variables for clarity These items have been evaluated and decided not to be implemented. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Replaces TODO comments with clear explanations that child classes intentionally omit @nexusrpc.service at definition time because the decorator is applied in the test function itself. This tests that service definitions correctly inherit operations from decorated parent classes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dandavison
reviewed
Jan 12, 2026
| def service_handler(cls: type[ServiceHandlerT]) -> type[ServiceHandlerT]: ... | ||
|
|
||
|
|
||
| # TODO(preview): allow service to be provided as positional argument? |
Contributor
There was a problem hiding this comment.
My thinking here was simply that it would be cleaner / more ergonomic to say @service_handler(MyService) rather than @service_handler(service=MyService) seeing as there's only one possible argument currently and even if we add more that would always be the most important argument.
Collaborator
Author
There was a problem hiding this comment.
I agree that it's the most important argument. There's currently a name arg and my initial take was that it seemed fine to require being explicit. I don't feel strongly about that position so I'd be happy to get this in the todo list if the increased ergonomics are worth it.
cretz
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the TODO comments, these ones were deemed as "won't do" currently. Happy to discuss that decision if there are any opinions.