Prevent setting method_name in Operation constructor #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method_name field should be automatically set by the framework to match the attribute name in service definitions or the method name in operation handlers. Users should not be able to set it directly. Changes: - Add init=False to method_name field in Operation dataclass - Update framework code to set method_name after Operation construction - Keep validation to catch manual method_name assignment that doesn't match the attribute name - Remove test case for duplicate method names via constructor (that specific scenario is no longer possible) - Update test expectations to not pass method_name to constructor Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method_name field should be automatically set by the framework to match the attribute name in service definitions or the method name in operation handlers. Users should not be able to set it directly.
Changes: