Document None vs type(None) semantics for type inspection #42
+56
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VegetarianOrc
commented
Jan 14, 2026
VegetarianOrc
commented
- Update docstring for get_start_method_input_and_output_type_annotations to clarify that None means "missing type" while type(None) means "explicitly annotated as None"
- Add comments explaining why type validation is skipped when handler types are None (relies on service definition for type information)
- Document why type inspection isn't deferred to @service_handler time (complexity not worth the marginal performance benefit)
- Add test case for @sync_operation with missing type annotations and no service definition to ensure the error flow is covered
- Update docstring for get_start_method_input_and_output_type_annotations to clarify that None means "missing type" while type(None) means "explicitly annotated as None" - Add comments explaining why type validation is skipped when handler types are None (relies on service definition for type information) - Document why type inspection isn't deferred to @service_handler time (complexity not worth the marginal performance benefit) - Add test case for @sync_operation with missing type annotations and no service definition to ensure the error flow is covered Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.