Feature: add androidReaderModeFlags option to pollTag #225
+69
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional flags to reader mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the androidReaderModeFlags option to poll(). There are a number of flags available but two of the most useful might be:
FLAG_READER_SKIP_NDEF_CHECK
When Android devices detect a tag they will perform an 'NDEF check' which seems to take around 500ms on a typical Samsung phone. Setting this flag has control straight to your app which means you can react much more quickly to tag detection.
FLAG_READER_NO_PLATFORM_SOUNDS
Disable the audio/haptic response on the phone. Useful if your NFC tag gives audio feedback and having the phone also do so is confusing.
The change is backwards compatible as the flag is optional.