fix(requests): update request results stuck 'fetching' (#542) #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request states are now updated using rxjs finalize() when still status: 'fetching'. This fixes an issue where observables were cached after immediately cancelling them.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #542
What is the new behavior?
If request results still have the status 'fetching' when finalizing, the status is set back to 'idle' and loading, success and error are all set to false.
Does this PR introduce a breaking change?
Other information
If we misunderstood something when using elf, we'd be happy to change things on our end.