Refactored with s6-overlay #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealGreenDragon
force-pushed
the
s6
branch
3 times, most recently
from
f6f3c92 to
e0a23e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38 .
I refactored this Docker image with s6-overlay to manage processes well and especially to restart
amulewebif it crashes.It is based on a little trick: if
amulewebis already running wait its PID to finish, otherwise start new instance.It runs
amuleweb --amule-config-file=/home/amule/.aMule/amule.confinstead of a standaloneamulewebbecause:amulewebstarted byamuled(I didn't see issues in all my tests)amulewebstarts with default webserver instead of what we choiced if we useremote.conf(maybe another bug...)I tried to not alter too much current aMule configuration initialization code:
amuledusing s6 instead kill