[WIP] Fix LeCroy WaveSurfer 3k #1033
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the support WaveSurfer 3k serie of scope.
Initially reported in #996 (and then partially reported in #1026 and #1028).
Most annoying issue is fixed in the current state : averaging is not present per channel but under
app.Acquisition.Horizontal.AverageSweeps. For now I have naively updated this path for the WS3k, but I suppose that this might cause issues if ngscopeclient expect an average setting per channel. Seems to work tho, but eager to implement a nicer fix once all the discrepencies with other LeCroy will be identified.Probe detection seems fixed, it was caused by abscence of probe mux being reported in differently than in other LeCroy scope: no .ActiveProbe property (and a differentt property for probe name).
Still investingating: