Merged
Conversation
…s during teleop after already running, remove explicit type argument of actions list in SimultaneousAction
Closed
AncientBison
requested changes
Jul 31, 2025
TeamCode/src/main/java/codebase/actions/SimultaneousAction.java
Outdated
Show resolved
Hide resolved
TeamCode/src/main/java/codebase/actions/SimultaneousAction.java
Outdated
Show resolved
Hide resolved
TeamCode/src/main/java/codebase/actions/SimultaneousAction.java
Outdated
Show resolved
Hide resolved
TeamCode/src/main/java/codebase/actions/SimultaneousAction.java
Outdated
Show resolved
Hide resolved
YoungerMax
requested changes
Jul 31, 2025
YoungerMax
left a comment
YoungerMax
left a comment
There was a problem hiding this comment.
See comment in response to Action... actions
…ction to require at least on Action parameter at compile time, change formatting of brackets and change wording of exception in SimultaneousAction, fix white space in ActionNode of SequentialAction
AncientBison
approved these changes
Aug 1, 2025
Contributor
AncientBison
left a comment
AncientBison
left a comment
There was a problem hiding this comment.
lgtm. I think the ActionNode system is more complicated than it has to be, but if the team agrees on that then I'm happy to merge this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.