Add support for develop branch nif.xml #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: This should be done for all formats NOTE: Makes sphinx take a LONG time to complete tho
Thats it, thats everything (lies).
Remove some comments Add some comments Add test for niftoolsxml bitstructattribute
Add update_version to NifFormat.Data that updates all block versions Skip attributes that haven't changed
Also added relative tests
Currently Skyrim SE is failing due to reaching end of file
StructBase read replaces the attributes as it reads not replaces before and reads (breaks) later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/pyffi-reviewer
Hi, I'm back from the dead. Recently got back into modding Bethesda games.
Overview
This pull request updates pyffi to be able to support the latest nif.xml. I am not done and I believe there are still more issues to fix. I also have more tests to write and disable/remove a lot of debug logging. All tests are working (at least on python 3.10).
I am currently not feeling well so I well fill out this pull request in detail later.
The way I got pyffi to work with the latest nif.xml is on reading stream, we update all attributes to be set the versions specified. I also duplicated xml object model into niftoolsxml because I didn't want to update all xmls right now to the new niftoolsxml specification.
TODO:
Implement conversions of attributes when updating attributesFixes Known Issues
[Ordered list of issues fixed by this PR]
Documentation
Added all object models to the documentation.
Testing
[Overview of testing required to ensure functionality is correctly implemented]
Manual
[Order steps to manually verify updates are working correctly]
Automated
Modified Expression tests to also test extra features
Added tests for importing files for specific games
Additional Information
I want to move away from nosetests, not because I dislike them but because I think we only need one test framefwork pytest.