modernize clipboard component with hooks.#79
Open
eightypop wants to merge 1 commit intonihey:masterfrom
Open
Conversation
Owner
|
Thanks for the major contribution, I'll take some time next week to review it and merge it. As for testing, I usually insert it into a project by linking it on its dependencies ( |
|
@nihey any chance working on that soon? |
Owner
|
@obsd Thanks for reviving this, yes, I should work on it soon, probably by next week. One thing that would really make the review & test process more simple are some tests, some end to end tests with something like Cypress would really be appreciated. |
|
Heyo, any updates? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses hooks instead of component lifecycle
note: how can i test this, i made changes but not sure how to test them.