Skip to content

Conversation

@localheinz
Copy link
Contributor

This PR

  • simplifies autoloading

Also see #62.

@staabm
Copy link

staabm commented Aug 9, 2018

Seems to be a BC break?

@localheinz
Copy link
Contributor Author

@staabm

How so?

@staabm
Copy link

staabm commented Aug 10, 2018

A app might expect/rely pn the fact that it can include a existing bootstrap.php file

@localheinz
Copy link
Contributor Author

@staabm

A app might expect/rely pn the fact that it can include a existing bootstrap.php file

A bit sad, but a good point!

@staabm
Copy link

staabm commented Aug 10, 2018

so you leave the bootstrap.php as is and add a deprecation comment on the top of it.

@rybakit
Copy link

rybakit commented Aug 10, 2018

so you leave the bootstrap.php as is and add a deprecation comment on the top of it.

But then you have to change require to require_once (or even remove all file inclusions), otherwise the files will be included twice?

@localheinz localheinz force-pushed the fix/autoload branch 2 times, most recently from 039e1c9 to f46deb1 Compare August 10, 2018 07:45
@jvasseur
Copy link
Contributor

Since master is supposed to be released as 2.0, doing BC breaks in it is fine.

@localheinz
Copy link
Contributor Author

@jvasseur

Sounds good, reverting the change, then!

@nikic
Copy link
Owner

nikic commented Mar 26, 2019

Manually applied in 33c2b7c. And yes, as this is for master only, I think it's fine to just drop the bootstrap.php file.

@nikic nikic closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants