fix: Explicitly mark parameters as nullable#42
fix: Explicitly mark parameters as nullable#42dimitri-guitton wants to merge 11 commits intonikolaposa:masterfrom
Conversation
…he explicit nullable type must be used instead
|
@d-loki Something is very off with code style in your fork. Check out the differences between: https://github.com/nikolaposa/version/blob/master/src/Version.php and https://github.com/nikolaposa/version/blob/bf7c73d71a5aafcad2d3c4801bfae50cc4103a91/src/Version.php where does that extra tab before every line comes from in your
|
…and checkGenericClassInNonGenericObjectType
Replace with :
ignoreErrors:
- identifier: missingType.generics
- identifier: missingType.iterableValue
|
@nikolaposa I’ll check and fix the issue. |
|
@nikolaposa I think it should be much better now. |
|
@d-loki Please fix these as well: https://github.com/nikolaposa/version/actions/runs/12990595086/job/36226775577?pr=42 |
It's fixed. |
|
Solved by #43 |
3 participants
This pull request addresses the deprecation warning related to implicitly marking parameters as nullable.