Skip to content

Explicit nullable types #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikolaposa merged 1 commit into from
Mar 5, 2025
Merged

Explicit nullable types #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class Version implements JsonSerializable

protected static ?Comparator $comparator = null;

final protected function __construct(int $major, int $minor, int $patch, PreRelease $preRelease = null, Build $build = null)
final protected function __construct(int $major, int $minor, int $patch, ?PreRelease $preRelease = null, ?Build $build = null)
{
VersionAssert::that($major)->greaterOrEqualThan(0, 'Major version must be positive integer');
VersionAssert::that($minor)->greaterOrEqualThan(0, 'Minor version must be positive integer');
Expand All @@ -44,7 +44,7 @@ final protected function __construct(int $major, int $minor, int $patch, PreRele
$this->build = $build;
}

public static function from(int $major, int $minor = 0, int $patch = 0, PreRelease $preRelease = null, Build $build = null): Version
public static function from(int $major, int $minor = 0, int $patch = 0, ?PreRelease $preRelease = null, ?Build $build = null): Version
{
return new static($major, $minor, $patch, $preRelease, $build);
}
Expand Down
Loading