Skip to content

chore: remove duplicated code from the update-and-merge of the core Agave repo#22

Merged
jason-nitro merged 1 commit intofeat/zkfrom
jdavis_remove_duplicated_lines
Jul 8, 2025
Merged

chore: remove duplicated code from the update-and-merge of the core Agave repo#22
jason-nitro merged 1 commit intofeat/zkfrom
jdavis_remove_duplicated_lines

Conversation

@jason-nitro
Copy link

As part of the merge, there were a number of merge artifacts inserted by the automated processes, most of which result in compilation problems. Some are just duplications that are wasteful, and some are comments.

@jason-nitro jason-nitro self-assigned this Jul 8, 2025
Copy link

@petarvujovic98 petarvujovic98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why I didn't actually get warned by these, there were at least twice as many which I removed, but these were somehow skipped??

P.S. Let's squash this together with my commit so that we always keep our changes in a single commit to reduce rebaseing steps and complications

@jason-nitro
Copy link
Author

Wonder why I didn't actually get warned by these, there were at least twice as many which I removed, but these were somehow skipped??

P.S. Let's squash this together with my commit so that we always keep our changes in a single commit to reduce rebaseing steps and complications

@petarvujovic98 Just to be clear, you did approve the PR, but also I should probably kill the PR and do the rebase or whatever.

Copy link

You can still merge the PR with the squash strategy, but then on the zk branch also squash the newly created commit into it's parent (my commit)

@jason-nitro jason-nitro merged commit e920759 into feat/zk Jul 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants