fix: Update memory-map of an AccountInfo struct to a VmAccountInfo#24
Merged
jason-nitro merged 4 commits intofeat/zkfrom Aug 7, 2025
Merged
fix: Update memory-map of an AccountInfo struct to a VmAccountInfo#24jason-nitro merged 4 commits intofeat/zkfrom
jason-nitro merged 4 commits intofeat/zkfrom
Conversation
* Compilation fixes after Agave update-and-merge * Update core/Cargo.toml Co-authored-by: Petar Vujović <petarvujovic98@gmail.com> --------- Co-authored-by: Petar Vujović <petarvujovic98@gmail.com>
petarvujovic98
approved these changes
Jul 10, 2025
petarvujovic98
left a comment
petarvujovic98
left a comment
There was a problem hiding this comment.
This feels a less evil than it already is - which makes it better
* Compilation fixes after Agave update-and-merge * Update core/Cargo.toml Co-authored-by: Petar Vujović <petarvujovic98@gmail.com> --------- Co-authored-by: Petar Vujović <petarvujovic98@gmail.com>
Author
Definitely removed some evil, which is how you can tell that having a VmAddress type (well, okay, it's just a u64) is the proper solution, not shoehorning things into Rust pointers when they're not exactly Rust pointers. |
petarvujovic98
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new Agave code does a fairly evil creation of an AccountInfo struct that uses a flattened piece of memory for all the parts to now do the same (but also less evilly) for VmAccountInfo.