Open
Conversation
Author
|
Doesn't fully build for other purposes right now, but can figure that out later.. we're not shipping it as a general getrandom solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't really a PR, because I pushed directly to the new v0.3.3-zkvm branch. But it's good for reviewing what I did. Comments still welcome.
getrandom v0.3.3 (which is used by Agave 3.0) changed their backend interface, so this is an updated version of the code needed to use this within an SP1 proof.
For the moment, this is just a trivial implementation of the function. Succinct should move this to their own fork and hook up the latest version of their randomization internals, which wasn't necessary for me to get this working.