feat: Add Scaleway serverless function preset #3970

Siilwyn · 2026-01-23T15:15:27Z

🔗 Linked issue

#2973

❓ Type of change

📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add Scaleway serverless functions preset.

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

Other

Open to all feedback, I'm figuring out what to add further to the documentation and preset config so deploys go as easy as possible.

vercel · 2026-01-23T15:15:32Z

@Siilwyn is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2026-01-23T15:15:35Z

📝 Walkthrough

Walkthrough

Adds a Scaleway Serverless preset: new preset module and runtime handler, updates preset registry and types, adds Scaleway deployment docs and an integration test, and adds @scaleway/serverless-functions as a devDependency. (30 words)

Changes

Cohort / File(s)	Summary
Scaleway preset & runtime `src/presets/scaleway/preset.ts`, `src/presets/scaleway/runtime/scaleway-serverless.ts`	New preset `scaleway-serverless` and runtime handler that adapts Scaleway serverless events into HTTP requests and forwards them to the Nitro app via `nitroApp.fetch`.
Preset registry `src/presets/_all.gen.ts`	Imports and includes the new Scaleway preset in the aggregated presets export.
Type updates `src/presets/_types.gen.ts`	Extends `PresetName` to include `"scaleway-serverless"` and `PresetNameInput` to accept `"scaleway-serverless"`, `"scalewayServerless"`, and `"scaleway_serverless"`.
Documentation `docs/2.deploy/20.providers/scaleway.md`	New documentation page for deploying Nitro apps to Scaleway Serverless.
Tests `test/presets/scaleway.test.ts`	New integration test that builds/loads the handler, starts a local HTTP server on a random port, and proxies fetch requests to validate the runtime.
Dev dependency `package.json`	Adds `@scaleway/serverless-functions` to `devDependencies`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title 'feat: Add Scaleway serverless function preset' follows conventional commits format with a descriptive summary that accurately reflects the main change of adding a new Scaleway preset.
Description check	✅ Passed	The pull request description is directly related to the changeset, clearly documenting the addition of the Scaleway serverless functions preset with linked issues, change types, and documentation updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

docs/2.deploy/20.providers/scaleway.md (1)

1-7: Consider adding basic deployment instructions.

The documentation is minimal compared to what users might need. A brief section covering how to deploy (e.g., the Scaleway CLI command, required environment variables, or a link to a step-by-step guide) would help users get started without leaving the Nitro docs.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Siilwyn · 2026-01-23T15:24:24Z

Moved from draft so CodeRabbit picks it up.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/presets/scaleway/runtime/scaleway-serverless.ts`:
- Around line 11-29: In handler, remove non-null assertions on event.headers and
event.queryStringParameters and guard them with safe fallbacks (e.g., const hdrs
= event.headers ?? {}; const qs = event.queryStringParameters ?? {}), iterate
hdrs safely when building headers map, and perform a case-insensitive lookup for
X-Forwarded-Proto (check hdrs["x-forwarded-proto"] and hdrs["X-Forwarded-Proto"]
or normalize keys) when composing the origin for joinURL; also handle body
decoding based on event.isBase64Encoded (decode to string/buffer when true) and
treat both GET and HEAD as having no body when constructing the Request. Ensure
you update references in handler to use these new locals (hdrs, qs, decodedBody)
and remove any remaining ! non-null assertions.

🧹 Nitpick comments (1)

docs/2.deploy/20.providers/scaleway.md (1)
1-7: Add a minimal config snippet for quicker onboarding.

A short nitro.config example would make the preset immediately actionable for readers skimming the page.
✍️ Example addition
 # Scaleway

 > Deploy Nitro apps to Scaleway.

 **Preset:** `scaleway-serverless`

+```ts
+// nitro.config.ts
+export default defineNitroConfig({
+  preset: "scaleway-serverless",
+});
+```
+
 :read-more{title="Scaleway Serverless Functions" to="https://www.scaleway.com/en/docs/serverless-functions/"}

src/presets/scaleway/runtime/scaleway-serverless.ts

coderabbitai · 2026-02-09T17:08:19Z

✅ Actions performed

Reviews resumed.

coderabbitai · 2026-02-09T17:09:56Z

✅ Actions performed

Full review triggered.

pi0 · 2026-02-09T17:42:12Z

src/presets/scaleway/preset.ts

+    },
+  },
+  {
+    name: "scaleway-serverless" as const,


We might choose a more clearname for this, perhaps We might choose a better name perhaps scaleway-functions?

(since we also have Scaleway serverless containers product)

pi0 · 2026-02-09T17:45:16Z

src/presets/scaleway/runtime/scaleway-serverless.ts

+      headers.get("Host")!,
+      event.path
+    ),
+    event.queryStringParameters ?? {}


Can you please refactor to use https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams to stringify queryStringParameters? (also don't we have access to original request string?)

pi0 · 2026-02-09T17:45:37Z

src/presets/scaleway/runtime/scaleway-serverless.ts

+import { useNitroApp } from "nitro/app";
+import { joinURL, withQuery } from "ufo";
+import type { serveHandler } from "@scaleway/serverless-functions";
+import { Buffer } from "node:buffer";


Buffer should be available globally

pi0 · 2026-02-09T17:47:56Z

src/presets/scaleway/preset.ts

+import { defineNitroPreset } from "../_utils/preset.ts";
+
+const scalewayServerless = defineNitroPreset(
+  {


we might enable serve static handler (with inlined contents) or explain it in docs (containers have better support for static assets i guess also)

pkg-pr-new · 2026-02-09T17:48:42Z

Open in StackBlitz

npm i https://pkg.pr.new/nitrojs/nitro@3970

commit: eea312f

Siilwyn force-pushed the scaleway branch 3 times, most recently from 1b2a136 to f8c6e3a Compare January 23, 2026 15:20

Siilwyn marked this pull request as ready for review January 23, 2026 15:24

Siilwyn requested a review from pi0 as a code owner January 23, 2026 15:24

coderabbitai bot reviewed Jan 23, 2026

View reviewed changes

src/presets/scaleway/runtime/scaleway-serverless.ts Show resolved Hide resolved

Siilwyn force-pushed the scaleway branch from 037c744 to ab873d4 Compare January 23, 2026 15:57

Siilwyn added 3 commits February 9, 2026 17:54

Add Scaleway serverless function preset

9c40243

Handle undefined query string parameters

6388c65

Handle header casing sensitivity

2e1aab3

Siilwyn force-pushed the scaleway branch from 1803cee to 0a72c5c Compare February 9, 2026 16:55

Siilwyn added 2 commits February 9, 2026 17:59

Add missing dependency @scaleway/serverless-functions

feb09f3

Handle base64 encoded body

71d53b9

Siilwyn force-pushed the scaleway branch from 0a72c5c to 71d53b9 Compare February 9, 2026 16:59

Run formatting

eea312f

pi0 reviewed Feb 9, 2026

View reviewed changes

Uh oh!

feat: Add Scaleway serverless function preset #3970

Are you sure you want to change the base?

feat: Add Scaleway serverless function preset #3970

Uh oh!

Conversation

Siilwyn commented Jan 23, 2026

🔗 Linked issue

❓ Type of change

📚 Description

📝 Checklist

Other

Uh oh!

vercel bot commented Jan 23, 2026

Uh oh!

coderabbitai bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Review ran into problems

Uh oh!

Siilwyn commented Jan 23, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot commented Feb 9, 2026

Uh oh!

coderabbitai bot commented Feb 9, 2026

Uh oh!

pi0 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

pi0 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

pi0 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

pi0 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 23, 2026 •

edited

Loading