Fix validation logic for the chat history #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a few changes to the validation logic, help display, and documentation for the server. The changes fix the validation of conversation history (#1 , #2) and update the help text and documentation to reflect the correct parameters.
Validation fixes:
packages/node/express/src/express/validators/chat/isValidConversationHistory.ts: Updated theisValidConversationHistoryfunction to include 'assistant' as a valid role in conversation history.Help text and documentation updates:
packages/node/server/src/serve/displayHelp.ts: Corrected the help text to use--api <openai>and--apiKey <key>instead of the previous--api <openapi>and--api-key <key>.pipeline/npm/server/README.md: Updated the README to reflect the correct usage of--api <openai>and--apiKey <key>parameters.Closes #1
Closes #2