Draft
Conversation
Then add tests for passing Poetry 2.x and 1.x versions to DockerManager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
DockerManagerto support both Poetry 1.x and 2.x versions when generating bash commands, and adds comprehensive tests to ensure correct behavior for both versions. The changes ensure compatibility with Poetry 2.x, which requires an additional export plugin and different command-line arguments.Poetry version compatibility improvements:
generate_bash_commandinsrc/managers/docker.pyto detect the Poetry major version and adjust the export command accordingly: installspoetry-plugin-exportand uses--with devfor Poetry 2.x, while retaining--devfor Poetry 1.x.Test enhancements:
tests/test_docker.pyto verify correct bash command generation for both Poetry 1.x and 2.x, and to check basic attributes and run command generation ofDockerManager.runmethod ofDockerManager, using mocking to avoid actual subprocess execution.