Skip to content

windows: mesure flakiness of failed tests #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardlau merged 3 commits into from
Sep 28, 2023
Merged

windows: mesure flakiness of failed tests #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b44ffae
windows: mesure flakiness of failed tests
aduh95 Oct 18, 2022
ba9c92f
Update node-test-binary-windows-native-suites.cmd
aduh95 Oct 18, 2022
7f1ddb1
Update node-test-binary-windows-js-suites.cmd
aduh95 Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jenkins/scripts/windows/node-test-binary-windows-js-suites.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ call %~dp0git-checkout.cmd
if errorlevel 1 exit /b

:: Run tests
set "test_ci_args=--run=%RUN_SUBSET%,4"
set "test_ci_args=--run=%RUN_SUBSET%,4 --measure-flakiness 9"
Copy link
Member

@richardlau richardlau Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work on earlier release lines? i.e. Node.js 14 and 16? We use the same jobs and scripts to test all supported release lines.

Copy link
Member

@mhdawson mhdawson Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo, good point

Copy link
Contributor Author

@aduh95 aduh95 Oct 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it fails: test.py: error: no such option: --measure-flakiness

I guess I need to first backport the changes before we can land this (it's already been backported to v16.x, I've opened nodejs/node#45126 to have it on v14.x as well).

Copy link
Contributor Author

@aduh95 aduh95 Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the backport has landed on v14.x, I think this can now move forward.

set VCBUILD_TARGET=test-ci-js
set FLAKY_TESTS=keep_retrying
call %~dp0test.cmd
if errorlevel 1 exit /b

Expand Down
3 changes: 2 additions & 1 deletion jenkins/scripts/windows/node-test-binary-windows-native-suites.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ call %~dp0git-checkout.cmd
if errorlevel 1 exit /b

:: Run tests
set "test_ci_args="
set "test_ci_args=--measure-flakiness 9"
set VCBUILD_TARGET=test-ci-native
set FLAKY_TESTS=keep_retrying
call %~dp0test.cmd
if errorlevel 1 exit /b

Expand Down