feat: default shell for alpine images#1380
Conversation
|
The change looks good but would it be possible to exclude the Yarn and signature key changes from the PR? |
f6fb099 to
9050986
Compare
|
Sure. I ran |
|
FWIW, I don't think it should be up to the docker image to tell npm not to "misbehave". Then again, this isn't a huge burden for us, so 🤷 /cc @nodejs/npm thoughts? |
|
Checked with the team and it does sounds like the default should be |
|
@ruyadorno thanks! Please let us know when it's fixed, so we can close this issue ;) |
|
@PeterDaveHello the fix went out in the |
|
Sure, thanks @ruyadorno |
|
Closing as the 15.1.0 images have been pushed to the docker hub |
|
For reference: npm/cli#2067 |
npmdefaultsshellandscript-shellconfig settings tobash, which is not available in alpine image.Npm 7 respects this setting and tries to call
bash -c 'git rev-parse ...'while trying to install package directly from git.Fixes #1378