Revert "Remove stray * for linux*-s390x in slim images"#2261
Merged
nschonni merged 1 commit intonodejs:mainfrom Jul 16, 2025
Merged
Revert "Remove stray * for linux*-s390x in slim images"#2261nschonni merged 1 commit intonodejs:mainfrom
nschonni merged 1 commit intonodejs:mainfrom
Conversation
There are linux32-s390x and linux64-s390x[1]. Copilot review was misleading. This reverts commit ec45cd2. [1] https://github.com/nodejs/node/tree/main/deps/openssl/config/archs
12 tasks
nschonni
approved these changes
Jul 16, 2025
Member
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
I'll land this as-is so the upstream PR gets fixed quickly, but might make sense to add a comment, since it wasn't obvious why the wildcard was used as a later thing
|
Created PR on the official-images repo (docker-library/official-images#19479). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are linux32-s390x and linux64-s390x[1].
Copilot review was misleading.
This reverts commit ec45cd2.
[1] https://github.com/nodejs/node/tree/main/deps/openssl/config/archs