updated output to include commercial timeperiod and a "< X" line as well#18
Open
joeeames wants to merge 2 commits intonodejs:mainfrom
Open
updated output to include commercial timeperiod and a "< X" line as well#18joeeames wants to merge 2 commits intonodejs:mainfrom
joeeames wants to merge 2 commits intonodejs:mainfrom
Conversation
Member
I don't know who are the group that approved this, but I feel this addition makes the graphic timeline much less legible and difficult to follow. Perhaps the timeline for commercial support should be a separate graphic with accompanying text explanation. |
richardlau
reviewed
Oct 25, 2024
| AddFullLineToTop(output, 'Main', 'unstable',); | ||
| } | ||
|
|
||
| AddFullLineToBottom(output, '<= v16', 'commercial'); |
Member
There was a problem hiding this comment.
This is Node.js specific (and time sensitive) and should not be encoded into the tooling.
Author
There was a problem hiding this comment.
oh. the tool should stay completely technology agnostic? Honestly I had no idea it wasn't just for Node. Got it. ok, I'll have to do some rework.
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
|
There are conflicts to fix, as well as some comments to address here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a bar for commercial time period per conversation on nodejs-tsc-herodevs slack and approval of this graphic:
