Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 29, 2023

Test results: https://github.com/cclauss/nan/actions

@rvagg Your review, please.

@cclauss cclauss force-pushed the patch-1 branch 2 times, most recently from 45275bc to a4c43c0 Compare January 13, 2025 08:21
@cclauss cclauss requested review from dsanders11 and kkoopa January 13, 2025 08:23
@cclauss
Copy link
Contributor Author

cclauss commented Jan 13, 2025

The tests pass so let’s merge without Node.js v23 until

@cclauss
Copy link
Contributor Author

cclauss commented Feb 2, 2025

@kkoopa Your review, please. It is surprising to find a https://github.com/nodejs repo with no automated testing.

@kkoopa
Copy link
Collaborator

kkoopa commented Feb 5, 2025

Sorry for the delay. I will look closer later, but for now it seems like there are only a couple versions tested here. Can this be extended to incorporate all the old, ugly releases? We actually do have CI testing, but most of it has broken or been discontinued over the years. AppVeyor still works however and it tests some 22 versions across multiple platforms.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 5, 2025

I cannot find the AppVeyor test results.

Can we see a nan-related URL like https://ci.appveyor.com/project/cclauss/appveyor-hack ?

@kkoopa
Copy link
Collaborator

kkoopa commented Feb 5, 2025 via email

@cclauss
Copy link
Contributor Author

cclauss commented Feb 9, 2025

@kkoopa asked:

Can this be extended to incorporate all the old, ugly releases?

actions/setup-node can indeed run ALL those old, ugly releases, and this demonstrates that most of them now pass.

I would very much appreciate a review of this and my other PRs so that we have updated AppVeyor and GitHub Actions testing in place before we merge solutions to key customer issues:

@cclauss cclauss changed the title GitHub Action to run tests on current versions of Node.js GitHub Action to run tests on all versions of Node.js Feb 9, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Feb 9, 2025

@tniessen Your review, please.

@cclauss cclauss changed the title GitHub Action to run tests on all versions of Node.js GitHub Action to run tests on most versions of Node.js Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants