test node 24 #997
Merged
test node 24 #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
https://github.com/nodejs/node/releases/tag/v24.0.0 Related to: @kkoopa Your review, please. |
Collaborator
|
The PR itself looks good, but is there any point of testing on Node 24 if not even 23 is working? |
Contributor
Author
|
I use latest version on node 23 and works for me 🤨 |
Contributor
|
@kkoopa Please enable the tests to run so we can see the results. In 6 months v24 will become the LTS release so we should encourage the community to get these tests to pass. |
Collaborator
|
That is an excellent point. Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.