feat: add warning when fail on all platforms#843
Merged
RafaelGSS merged 1 commit intonodejs:mainfrom Aug 24, 2024
Merged
Conversation
1bb22a7 to
9da893b
Compare
ruyadorno
approved these changes
Aug 23, 2024
marco-ippolito
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motived by the recent regression on Node.js 22.7.0. Apparently, the CITGM did catch the potential regression on
throughvpackage. But, due to the number of failures on CITGM, I somehow missed this module in my analysis: nodejs/node#54452 (comment).So, this PR makes sure to include a warning whenever a module fails in all platforms. So, the previous CITGM comparison would tell the following:
@nodejs/releasers