Closed
Conversation
The completion lists used a hand crafted list of global entries that was redundant due to also using the actual global properties for tab completion. Those entries ended up in an separated completion group which did not seem useful.
In case no error has occurred during the evaluation of some code, `undefined` has been returned in some cases as error argument instead of `null`. This is fixed by this patch.
It is checked if an command buffer exists or not. This code branch can only be reached if non exist, so there's no need to clear that buffer again.
The removed line does not add anything of value to the test. It was removed to simplify the test.
targos
approved these changes
Jan 27, 2019
Member
Author
BridgeAR
added
the
author ready
bnoordhuis
approved these changes
Jan 28, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
There's a typo in the third commit log: s/non/none/
| for (const name of Object.getOwnPropertyNames(global)) { | ||
| Object.defineProperty(context, name, | ||
| Object.getOwnPropertyDescriptor(global, name)); | ||
| } |
Member
There was a problem hiding this comment.
Does this really skip console like it used to? Raw V8 contexts have a (primordial) console property.
It's quite possible the answer is "it doesn't matter either way" but I thought I'd ask anyway. :)
Member
Author
There was a problem hiding this comment.
It does not skip it. Instead, it just sets it twice. The overhead should be minimal and it's less code that way, so it seemed fine to me.
danbev
pushed a commit
that referenced
this pull request
Feb 6, 2019
The completion lists used a hand crafted list of global entries that was redundant due to also using the actual global properties for tab completion. Those entries ended up in an separated completion group which did not seem useful. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
danbev
pushed a commit
that referenced
this pull request
Feb 6, 2019
In case no error has occurred during the evaluation of some code, `undefined` has been returned in some cases as error argument instead of `null`. This is fixed by this patch. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
danbev
pushed a commit
that referenced
this pull request
Feb 6, 2019
It is checked if an command buffer exists or not. This code branch can only be reached if none exist, so there's no need to clear that buffer again. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
danbev
pushed a commit
that referenced
this pull request
Feb 6, 2019
The removed line does not add anything of value to the test. It was removed to simplify the test. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
The completion lists used a hand crafted list of global entries that was redundant due to also using the actual global properties for tab completion. Those entries ended up in an separated completion group which did not seem useful. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
In case no error has occurred during the evaluation of some code, `undefined` has been returned in some cases as error argument instead of `null`. This is fixed by this patch. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
It is checked if an command buffer exists or not. This code branch can only be reached if none exist, so there's no need to clear that buffer again. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
The removed line does not add anything of value to the test. It was removed to simplify the test. PR-URL: #25731 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
This was referenced Feb 15, 2019
starkwang
added a commit
to starkwang/node
that referenced
this pull request
Jun 4, 2019
The global object in repl conetxt is copied from main context, which breaks the behavior of `instanceof`. This change reverts nodejs#25731. Fixes: nodejs#27859 Refs: nodejs#25731
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please have a look at the commit messages for further descriptions. This is mainly something I stumbled upon while working on #20803.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes